8f63167 CHART: add additionalProperties for falco-exporter service Monitor #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
|
Welcome @ArnaudCHT! It looks like this is your first PR to falcosecurity/charts 🎉 |
ArnaudCHT
changed the title
|
LGTM label has been added. Git tree hash: aa9a65091187e1d4c4710708a7a07240e4b586e0
|
|
Can you sign off your commits and run |
|
Hello, I sign off the commits and run |
|
This DCO is still wrong, are you sure having signed off the commit? |
Signed-off-by: Arnaud CHATELAIN <[email protected]>
|
My bad. This should be OK now ! |
Issif
approved these changes
Apr 29, 2024
|
LGTM label has been added. Git tree hash: 0efa28ea0a15d5c4385ee1203cb5fbf399d83929
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArnaudCHT, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falco-exporter-chart
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I've added the capability to the Falco-exporter charts to set additional properties within the Service Monitor, such as relabelings, metricRelabelings, etc.
I ran a Helm template and tested the Service Monitor in an OpenShift cluster.
commit : 8f63167
Checklist